Add external URL endpoint options for the console (close #2824) #3570
Conversation
|
Beep boop! 🤖 Hey @ashishra0, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
Deploy preview for hasura-docs ready! Built with commit fa0be03 |
ashishra0
changed the title
|
Review app for commit 6fb6cff deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
ashishra0
changed the title
|
Review app for commit 86674ec deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
|
Review app for commit 320050c deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
|
Review app for commit 2902c5d deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
|
Review app for commit 9072a91 deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
|
Review app for commit f4e6b4b deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
kolharsam
requested review from
beerose and
scriptonist
and removed request for
rikinsk
| // FIXME: My Router struct | ||
| r := &cRouter{ | ||
| g, | ||
| t, | ||
| } |
There was a problem hiding this comment.
@scriptonist I'm marking 4 FIXME comments that I need help with. Basically wanted to know if there are alternate structures or methods that need to be used in order to get this PR up to speed.
| // FIXME: DoAssetExist | ||
| if !util.DoAssetExist("assets/" + assetsVersion + "/console.html") { | ||
| assetsVersion = "latest" | ||
| } |
| // FIXME: LoadTemplates | ||
| templateRender, err := util.LoadTemplates("assets/"+assetsVersion+"/", "console.html") |
| // FIXME | ||
| host := getFilePath(dir) | ||
| c.Set("filedir", host) | ||
| c.Next() |
|
Review app for commit a146d85 deployed to Heroku: https://hge-ci-pull-3570.herokuapp.com |
|
Are there any progresses with this one? This is an important feature, especially in a multi-developer setup where schema changes must be tracked centrally. |
|
Will this ever get merged? I need it too... |
|
What's the status on this? A lot of people would really appreciate this merged in |
|
Hi all, could you please approve this?? We are waiting for this feature in Userland |
|
Sameer Kolhar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @ashishra0 , Thank you for raising this PR! We recently merged a change that allows the CLI to set a custom HGE endpoint for the console (more details). Could you please tell me how much of your usecase is solved by that? |
|
Beep boop! 🤖 Hey @ashishra0! Sorry that your PR wasn’t merged. Do take a look at any of the other open issues to see if you’d like to take something up! We’re around on Discord if you have any questions 😄 |
|
what is the solution here is it merge or ? |
Description
This PR adds two external URL endpoint options for the Hasura console.
Currently, There are no options configured.
Also, all requests going through CLI must be protected by the access key.
Affected components
Related Issues
#2824
Solution and Design
Add a flag each for external server endpoint and external cli endpoint.
Add a check for access key in the request body.